Skip to content

Make get_random feature dependent on rand_core#2450

Closed
eligrubb wants to merge 1 commit into
RustCrypto:masterfrom
eligrubb:get-random-rand-core
Closed

Make get_random feature dependent on rand_core#2450
eligrubb wants to merge 1 commit into
RustCrypto:masterfrom
eligrubb:get-random-rand-core

Conversation

@eligrubb

Copy link
Copy Markdown

Fixes AEADs Issue#755. See also alternative solution, AEADs PR#833.

The Generate trait is used by rustdoc code demonstrating various AEADs getrandom feature, but the Generate trait is gated by the rand_core feature, which is not always enabled when getrandom is enabled. This is causing compilation errors for rustdoc tests that use Generate for Nonce generation.

@tarcieri

Copy link
Copy Markdown
Member

Looks like you have a syntax error. I went ahead and took care of it in #2452

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Doctests no longer build with default features

2 participants